node-xcode icon indicating copy to clipboard operation
node-xcode copied to clipboard

addToLibraryHeaderSearchPaths - handle non-inherited single values

Open grabbou opened this issue 8 years ago • 5 comments

Fixes #94. Locally all tests are green, meaning that the change is at least backwards compatible. Not sure if we need any extra test-case for that as the conversion to an array already happens for all $(inherited) values, which is covered.

grabbou avatar May 29 '16 20:05 grabbou

Any chance you can take a look on it soon, @alunny? 🙏

Kureev avatar May 31 '16 10:05 Kureev

@grabbou any chance you could add a test for single values please ?

imhotep avatar May 31 '16 13:05 imhotep

Will do later today. BTW, isn't that already covered by all values = "$(inherited)" ?

grabbou avatar May 31 '16 16:05 grabbou

@grabbou is there a test for .push is undefined ?

imhotep avatar Jun 01 '16 22:06 imhotep

Nope since we don't use it anywhere in that method (the error was coming from our code). Now that we convert all string values to an array (not just inherited) https://github.com/alunny/node-xcode/pull/96/files#diff-35bc421794193e73d972308b4f2f3598R1175 it's not going to happen :)

grabbou avatar Jun 09 '16 00:06 grabbou