fast_matrix_market icon indicating copy to clipboard operation
fast_matrix_market copied to clipboard

Specify STATIC in add_library

Open dariomangoni opened this issue 3 months ago • 0 comments

In dependencies/ryu/CMakeLists.txt, by calling add_library without the STATIC option, the choice between STATIC or SHARED is left to the BUILD_SHARED_LIBS option, set anywhere else in the parent CMake files.

However, since the CMake is currently not working with SHARED (at least on Win), thus implicitly restricting the build to STATIC only, might be worth to explicitly ask for STATIC?

I might be missing something.

I proposed the change in the original repo as well

dariomangoni avatar Apr 02 '24 13:04 dariomangoni