gitu icon indicating copy to clipboard operation
gitu copied to clipboard

Fix a process bug when running show commands on Windows

Open damienstanton opened this issue 9 months ago • 2 comments

With the released version, all gitu commands for showing, editing etc. using the EDITOR env var and others will fail because we try to launch the subprocess command directly.

On Windows, this doesn't work; Commands need to be prepended with cmd /C to be executed in sub-shells.

damienstanton avatar Mar 13 '25 13:03 damienstanton

Note that there are some tests that this currently breaks, so I'll fix these before calling it ready to merge.

damienstanton avatar Mar 13 '25 14:03 damienstanton

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 87.73%. Comparing base (c772624) to head (ead232d). :warning: Report is 116 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   87.71%   87.73%   +0.01%     
==========================================
  Files          63       63              
  Lines        5627     5636       +9     
==========================================
+ Hits         4936     4945       +9     
  Misses        691      691              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 15 '25 08:03 codecov[bot]

edit: code seems fine, I'll merge this and just change the commit title to generate a changelog. Not sure about the test situation on windows, it shouldn't be trying to open an editor from the tests I believe.

altsem avatar Sep 07 '25 12:09 altsem