pyfamsa icon indicating copy to clipboard operation
pyfamsa copied to clipboard

Crash when using pyFAMSA

Open maovshao opened this issue 1 year ago • 2 comments

Hi @althonos,

I am writing to express my gratitude for the updates on scoring-matrices in Version 0.4.0. The enhancements have been incredibly beneficial.

I have also noticed your attempts to resolve the crash bug as seen in https://github.com/refresh-bio/FAMSA/issues/46 and https://github.com/refresh-bio/FAMSA/pull/47. Unfortunately, it appears this Pull Request has not yet garnered the anticipated response.

Given that Pyfamsa is a standalone project built using Cython, I wonder if it would be possible to merge this PR into the Pyfamsa's famsa source code and then recompile with Cython. This could potentially provide a swift resolution to the problem at hand.

As a devoted user of Pyfamsa, I offer this suggestion in the hopes of furthering the progress and success of this project. I genuinely wish for the continued growth and improvement of both Pyfamsa and your team.

Best.

maovshao avatar Jun 03 '24 13:06 maovshao

Hello @maovshao ,

Martin's pull requests are actually not the solutions of the reported crashes (though, they should have been accepted quite ago - sorry Martin ;)). I'll try to take a look at this and incorporate a fix into FAMSA in a few days.

Best, Adam

agudys avatar Jun 03 '24 13:06 agudys

Sorry, my bad to misunderstand. Also, I'm more than happy to see your quick reply.

Looking forward to your update.

Best.

maovshao avatar Jun 04 '24 04:06 maovshao