fs.sshfs icon indicating copy to clipboard operation
fs.sshfs copied to clipboard

Add a timeout argument to _exec_command

Open dhirschfeld opened this issue 6 years ago • 7 comments

Fixes #15

dhirschfeld avatar Jul 21 '18 02:07 dhirschfeld

This is the minimum fix required to get fs.sshfs working for my usecase.

dhirschfeld avatar Jul 21 '18 02:07 dhirschfeld

This appears to have caused something else to hang? I don't think this change should have done that.

dhirschfeld avatar Jul 21 '18 08:07 dhirschfeld

@dhirschfeld: I think the hang comes from additional tests Will has added to Pyfilesystem2 in the latest release. They also cause one of my other extensions to hang. I'll investigate.

althonos avatar Jul 23 '18 12:07 althonos

Is that the worker threads change to copy/move? Could have exposed a thread-safety issue.

I've just recalled there is a thread_safe meta value. I should probably do a non-threaded copy if that is False.

willmcgugan avatar Jul 23 '18 13:07 willmcgugan

@willmcgugan : probably, yes !

Still, I expected this extension to be thread-safe since I'm locking whenever I access the underlying _sftp attribute !

althonos avatar Jul 23 '18 13:07 althonos

RE: thread safety, see also #17.

dhirschfeld avatar Jul 23 '18 23:07 dhirschfeld

Codecov Report

Merging #16 into master will decrease coverage by 0.63%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   97.41%   96.78%   -0.64%     
==========================================
  Files           5        5              
  Lines         310      311       +1     
==========================================
- Hits          302      301       -1     
- Misses          8       10       +2
Impacted Files Coverage Δ
fs/sshfs/sshfs.py 95.28% <66.66%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f57437...c0ed6ab. Read the comment docs.

codecov-io avatar Sep 02 '18 03:09 codecov-io