woodwork icon indicating copy to clipboard operation
woodwork copied to clipboard

Add Boolean Inference

Open bchen1116 opened this issue 2 years ago • 1 comments

bchen1116 avatar Oct 25 '22 16:10 bchen1116

Codecov Report

Merging #1549 (9bc1d1a) into main (13b37a4) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files          91       91           
  Lines       10813    10891   +78     
=======================================
+ Hits        10696    10774   +78     
  Misses        117      117           
Impacted Files Coverage Δ
woodwork/config.py 100.00% <ø> (ø)
woodwork/tests/accessor/test_serialization.py 100.00% <ø> (ø)
woodwork/tests/type_system/conftest.py 100.00% <ø> (ø)
woodwork/tests/utils/test_read_file.py 100.00% <ø> (ø)
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_statistics.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_table_accessor.py 100.00% <100.00%> (ø)
woodwork/tests/conftest.py 100.00% <100.00%> (ø)
woodwork/tests/logical_types/test_logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/testing_utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 25 '22 16:10 codecov[bot]

No big change in runtime. Perf test report is attached 3109.html.zip

bchen1116 avatar Oct 27 '22 17:10 bchen1116

Leaving this unmerged for the 0.20.0 release because it introduces a lot of breaking changes. Will aim to get in for 0.21.0 release.

bchen1116 avatar Oct 31 '22 14:10 bchen1116

Leaving this unmerged for the 0.20.0 release because it introduces a lot of breaking changes. Will aim to get in for 0.21.0 release.

Can we also add all documented breaking changes to the release notes?

ParthivNaresh avatar Nov 01 '22 07:11 ParthivNaresh

Changing to npartitions=-1, as per @thehomebrewnerd's suggestion, leads to slightly better times on the perf tests. 3160.html.zip

Will keep this change over .compute()

bchen1116 avatar Nov 02 '22 17:11 bchen1116