featuretools
featuretools copied to clipboard
alteryx
1272: Remove allowed types
Pull Request Description
leave only pd.Series as a valid input type for instance_vals in Entityset.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request.
@Kryvonis thank you for putting up this pull request. I'm curious, why would it be beneficial to support less types?
@Kryvonis thank you for putting up this pull request. I'm curious, why would it be beneficial to support less types?
@gsheni See this issue for context: https://github.com/alteryx/featuretools/issues/1272
@Kryvonis in order for the CLA bot to work correctly it needs the author email on the commits to match an email linked with your github account
@rwedge Sorry, my fault. I didn't know about that rule. I tried to amend email but Git add new commits. Do I need to remove previous commits?
@Kryvonis You can also create a new branch off Featuretools main, copy the changes from here, and put up a new pull request in a new branch. Be sure to use the same author email on the commits as your GitHub account.
I think I already fixed author commits but I don't know is there ok that some tests are failed
@Kryvonis You need to sign the CLA: https://cla-assistant.io/alteryx/featuretools?pullRequest=2301
Hi Kryvonis, thanks for doing this!
I believe one of the reasons the tests are failing is that the query_by_values method is being called with Dask or PySpark series arguments for the instance_vals parameter. Also, I believe the lines 1874 and 1877 in _vals_to_series are doing necessary logic. One way to handle this would be to keep the _vals_to_series method. We could stop handling the single value case and dataframe case and keep the other cases.
@thehomebrewnerd @rwedge @gsheni Feel free to change this if I am misunderstanding something!
