featuretools icon indicating copy to clipboard operation
featuretools copied to clipboard

Potentially explore having get_function be available as a decorator

Open ozzieD opened this issue 2 years ago • 5 comments

get_function is repeated throughout every primitive. I purpose we explore the idea of making this available as a decorator instead which wraps the function needed to run in order to obtain the output. We could also add decorators for spark or dask specific functions as @rwedge mentioned.

ex:

class ExamplePrimitve
  def get_function(self):
        def example_function(x):
           #some logic here
            return something
        return example_function

to

class ExamplePrimitve
@get_function
    def example_function(x):
        #some logic here
         return something

ozzieD avatar Jul 15 '22 17:07 ozzieD

Assign this issue to me, I can fix it!

Abdullium avatar Aug 07 '22 05:08 Abdullium

@Abdullium sure, assigned the issue to you.

gsheni avatar Aug 08 '22 14:08 gsheni

@Abdullium sure, assigned the issue to you.

Well can you tell me where exactly i have to replace the feature,

Abdullium avatar Aug 08 '22 17:08 Abdullium

@Abdullium on closer inspection, this is a Featuretools 2.0 issue and something we need a design document for. I would suggest looking at doing one of these other issues if you would like to help out:

  • https://github.com/alteryx/featuretools/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

gsheni avatar Aug 08 '22 17:08 gsheni

@Abdullium on closer inspection, this is a Featuretools 2.0 issue and something we need a design document for. I would suggest looking at doing one of these other issues if you would like to help out:

  • https://github.com/alteryx/featuretools/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

I got confused as it was labelled as good first issue But anyway

Do you know projects which could use help from data analysis person

Abdullium avatar Aug 08 '22 17:08 Abdullium