featuretools icon indicating copy to clipboard operation
featuretools copied to clipboard

Handle _check_cutoff_time_type with Woodwork logic

Open tamargrey opened this issue 2 years ago • 0 comments

Currently, _check_cutoff_time_type uses a custom _check_time_type util that has slightly different logic for identifying numeric vs datetime columns than Woodwork has.

If possible, we should use Woodwork logic for identifying the cutoff time type even when the cutoff time is a single value.

I'm imagining a situation where we add the single cutoff time to a series and initialize woodwork on it. Then we can use the same logic for the single cutoff time value as we use for the series in _check_cutoff_time_type. This would let us remove _check_time_type and any related code.

It might make sense to wait for https://github.com/alteryx/woodwork/issues/1341 to be done, however, so Featuretools could benefit from the addition of the datetime.date type to the datetime inference (if that's what ends up happening). The potential need for datetime.date came up first in https://github.com/alteryx/featuretools/issues/150.

tamargrey avatar Mar 15 '22 22:03 tamargrey