evalml icon indicating copy to clipboard operation
evalml copied to clipboard

Decrease runtime of lint job

Open angela97lin opened this issue 4 years ago • 1 comments
trafficstars

#2670 introduced pydocstyle and darglint packages. The darglint package specifically increases the runtime of our lint job by a few minutes. While we were okay with this addition, I suspect that there's a way to cut down on this time. Some suggestions are:

  • Find a way to only lint the changed files. @freddyaboulton mentioned that scikit-learn has a way to do so via bash script that might be worth exploring: https://github.com/alteryx/evalml/pull/2670#issuecomment-918578759
  • Explore github pre-commit hooks, and only call the lint job on files modified (that are not test files, and .py files).

angela97lin avatar Sep 14 '21 18:09 angela97lin

Thanks for filing! Please use the "spike" label instead of "[SPIKE]" title prefix

dsherry avatar Sep 15 '21 19:09 dsherry