Kyle Altendorf

Results 572 comments of Kyle Altendorf

That's why I put it up here sooner than later, thanks. I made `Converter` to be like `Factory` is for `default=`. Though the calling side didn't end up so similar...

@hynek, I figured it would make sense to clarify the logic before writing up docs etc. I didn't quite understand how your suggestion would make the diff much simpler. Do...

I'm not sure if storing a `Converter()` regardless in `names_for_globals` is a tidy way to increase consistency in this code while retaining the outward appearance of whatever the caller passed...

One attribute is `float_factory` which defaults to `float` but may also be `decimal.Decimal` or such. Whatever is passed in for the `offset` attribute should be converted using the `float_factory` attribute....

https://travis-ci.org/python-attrs/attrs/jobs/401284405#L510 ``` would reformat /home/travis/build/python-attrs/attrs/tests/test_make.py ``` I don't get this locally and it's not telling me what line etc... but apparently I guessed correctly.

040f2b978147837f8f0f0b0880012da2f43904a6 adds a test for my desired behavior of `attr.fields(C).a.converter` being the object passed via `attr.ib(converter=f)`. I figure that as long as my code is targeting that, it should have...

@glyph, the short explanation is that the converter is actually configurable via a 'previous' attribute. The library was hardcoded with float but I wanted to use decimal so I introduced...

I don't have a problem doing 'something else' like suggested. I implemented the way it is because there was a ticket open for the decorator and because I figured symmetry...

My comments about expecting this (concept) to just be accepted weren't meant to express frustration. Rather just that I hadn't put a lot of thought into the concept making sense...

What if attrs created the `@classmethod`? As another option, I joked recently about `attr.with_converter(TheClass)(x, y)` as well. Or the opposite such as `attr.raw_init(TheClass)`. The basic point is that you should...