altair icon indicating copy to clipboard operation
altair copied to clipboard

When the docs are shown, the Touch Bar should show a "Hide Docs" button

Open thomasio101 opened this issue 3 years ago • 28 comments

Is your feature request related to a problem? Please describe. I use Altair on my MacBook Pro and noticed that the Touch Bar is showing a "Show Docs" button, even when the docs are already shown.

Describe the solution you'd like Whenever the docs are shown, the aforementioned button should say "Hide Docs".

Describe alternatives you've considered I haven't considered any alternatives.

Additional context When the app is showing the docs, like this: Screenshot 2021-08-20 at 12 15 44 The touch bar still shows the "Show Docs" button: Touch Bar Shot 2021-08-20 at 12 15 46

thomasio101 avatar Aug 20 '21 10:08 thomasio101

Thanks for reporting this! I'd look into it as soon as I can. Note you can also create a PR to resolve this issue faster.

imolorhe avatar Aug 31 '21 17:08 imolorhe

I would like to work on this issue. Do assign if no one else is working on it. @imolorhe

anonymous-baaka avatar Jan 30 '23 10:01 anonymous-baaka

Feel free to work on it

imolorhe avatar Jan 30 '23 20:01 imolorhe

I would Like to work on this issue. @anonymous-baaka are you working on it?

Aryan1982 avatar Feb 22 '23 11:02 Aryan1982

Has this been fixed? @imolorhe

mani91g avatar Apr 02 '23 02:04 mani91g

@mani91g No it hasn't

imolorhe avatar Apr 02 '23 06:04 imolorhe

Hello @imolorhe ,Can i pick this up??

saikiran96 avatar Apr 02 '23 19:04 saikiran96

@saikiran96 Please anyone can pick it up as it is not assigned.

imolorhe avatar Apr 02 '23 20:04 imolorhe

is it fixed?

SaunakNandi avatar Sep 09 '23 15:09 SaunakNandi

@imolorhe can u tell me what are the packages that I have to install inorder to run the project?

SaunakNandi avatar Sep 09 '23 16:09 SaunakNandi

If you want to work on this, that means you're working on the electron app. To run that, you can run yarn install from the root of the repo to install the packages and autolink the packages. Then you should be able to go into packages/altair-electron and run yarn dev to get the local electron app running

imolorhe avatar Sep 09 '23 21:09 imolorhe

@imolorhe can u tell me how to do the same thing in the GitHub cloudspace?

SaunakNandi avatar Sep 10 '23 10:09 SaunakNandi

@imolorhe Can I take up this issue?

Shwetapal9 avatar Oct 15 '23 13:10 Shwetapal9

Hello! I'm interested in working on this issue. Could someone please assign it to me or provide some guidance on how I can get started? Thanks!

abhisheksharma010 avatar Oct 21 '23 08:10 abhisheksharma010

@imolorhe I'm taking on this issue.

vaishnv-sn avatar Dec 11 '23 18:12 vaishnv-sn

Hi @imolorhe , I am unable to set up this project locally, after running yarn install my node modules are not getting installed. Can you suggest where I am missing the step?

tanviagwl98 avatar Jan 06 '24 10:01 tanviagwl98

@tanviagwl98 are you getting any errors?

imolorhe avatar Jan 10 '24 06:01 imolorhe

Yes I am getting errors while installing to share screenshot I will have to run it again, will need sometime for that @imolorhe

tanviagwl98 avatar Jan 10 '24 06:01 tanviagwl98

Also are you running it in windows or mac?

imolorhe avatar Jan 10 '24 06:01 imolorhe

It is on windows

tanviagwl98 avatar Jan 10 '24 06:01 tanviagwl98

@imolorhe Hi, I was trying to look into issue but can't get past the below error while running yarn dev :

$ yarn dev yarn run v1.18.0 $ yarn compile && electron ./dist/ $ tsc && yarn sentry:sourcemaps:inject src/app/actions.ts(6,34): error TS2307: Cannot find module '@altairgraphql/electron-settings-static' or its corresponding type declarations. src/app/index.ts(12,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. src/app/window.ts(12,8): error TS2307: Cannot find module 'altair-static' or its corresponding type declarations. src/app/window.ts(32,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. src/app/window.ts(33,29): error TS2307: Cannot find module 'altair-graphql-core/build/types/state/header.interfaces' or its corresponding type declarations. src/app/window.ts(164,25): error TS7006: Parameter 'header' implicitly has an 'any' type. src/electron-store-adapter/main-store-events.ts(1,30): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. src/settings/main/events.ts(7,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. src/settings/main/store.ts(5,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. src/utils/index.ts(6,40): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations. error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any suggestions on what am I missing?

nishantguvvada avatar Feb 27 '24 09:02 nishantguvvada

@nishantguvvada did you already run yarn install from the root of the repo?

imolorhe avatar Feb 27 '24 10:02 imolorhe

@imolorhe Encountered this error when running yarn install from the root of the repo (seems to be some issue with the version):

$ yarn install yarn install v1.18.0 [1/5] Validating package.json... [2/5] Resolving packages... warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning Resolution field "[email protected]" is incompatible with requested version "y18n@^5.0.5" warning [email protected]: Please use @electron/asar moving forward. There is no API change, just a package name change warning babel-polyfill > [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js. warning [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js. warning [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. warning [email protected]: Please use @electron/notarize moving forward. There is no API change, just a package name change warning [email protected]: Use promise-toolbox/fromEvent instead warning [email protected]: flatten is deprecated in favor of utility frameworks such as lodash. warning [email protected]: this package has been merged into graphql-language-service warning [email protected]: Removed event-stream from gulp-header warning [email protected]: this library is no longer supported warning [email protected]: Support has ended for 9.x series. Upgrade to @latest warning [email protected]: this will be v4 warning [email protected]: Multer 1.x is affected by CVE-2022-24434. This is fixed in v1.4.4-lts.1 which drops support for versions of Node.js before 6. Please upgrade to at least Node.js 6 and version 1.4.4-lts.1 of Multer. If you need support for older versions of Node.js, we are open to accepting patches that would fix the CVE on the main 1.x release line, whilst maintaining compatibility with Node.js 0.10. warning [email protected]: Important: For Angular v9+ please use the until-destroy library: https://github.com/ngneat/until-destroy#use-with-ivy warning Resolution field "[email protected]" is incompatible with requested version "[email protected]" warning Resolution field "[email protected]" is incompatible with requested version "[email protected]" warning Resolution field "[email protected]" is incompatible with requested version "[email protected]" warning [email protected]: We have news to share - Protractor is deprecated and will reach end-of-life by Summer 2023. To learn more and find out about other options please refer to this post on the Angular blog. Thank you for using and contributing to Protractor. https://goo.gle/state-of-e2e-in-angular warning [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. warning [email protected]: This functionality has been moved to @npmcli/fs warning [email protected]: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142 warning [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. warning [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. warning [email protected]: Backported compatibility to node > 6 warning [email protected]: See https://github.com/lydell/source-map-url#deprecated warning [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. error Couldn't find any versions for "string-width-cjs" that matches "^4.2.3" info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

nishantguvvada avatar Feb 27 '24 15:02 nishantguvvada

@nishantguvvada Did you modify the yarn.lock file? Seems you have an issue with the dependency version resolution.

imolorhe avatar Feb 28 '24 07:02 imolorhe

I want to work for the issue .. Does this issue is already resolved if not allow me contribute

utkarshilh avatar Apr 08 '24 09:04 utkarshilh

How Do We get the touchbar As I can't see nay when I downloaded it image

nehagupta1504 avatar Apr 09 '24 13:04 nehagupta1504