cargo-quickinstall icon indicating copy to clipboard operation
cargo-quickinstall copied to clipboard

misc places where we could catch errors earlier

Open alsuren opened this issue 2 years ago • 1 comments

Feel free to add things as you see them. Probably not worth having a separate issue for each one, but having a bunch of known issues sitting in my head probably isn't that helpful to anyone, so I thought I'd start writing them down as I think of them.

  • [ ] cargo-deny takes ages to build. Can we catch broken CC with a slightly smaller package?
  • [ ] "Build Thyself" step doesn't check that the tarball contains exactly cargo-quickinstall and nothing else (https://github.com/cargo-bins/cargo-quickinstall/pull/140/files#r1089714376)
  • [ ] if curl isn't there (happens on some docker images) we print Error: No such file or directory (os error 2) without telling the user that they need to install curl (took me a while when debugging aarch64 installs in docker)
  • [ ] trigger-package-build.sh bakes the current branch name into the template, but it doesn't check that you remembered to push your branch, so it could fail (or build with stale code). It might also be valuable to bake the branch name into the title so you can more easily distinguish manually-triggered builds from cronjob ones.
  • [ ] ...

alsuren avatar Jan 29 '23 14:01 alsuren

+1 for the curl issue !

vic1707 avatar May 31 '25 22:05 vic1707