al-folio icon indicating copy to clipboard operation
al-folio copied to clipboard

Add Docker-compose file for windows WSL compatibility

Open pourmand1376 opened this issue 2 years ago • 3 comments

This file makes it easier for windows users to use docker. (Closes #829)

Previous to this commit, those how use Windows have to install Ubuntu inside windows (via WSL) and run our commands. Now they can run it by just typing docker-compose up.

The main problem was that ./bin/dockerhub_run.sh command was written with Bash in mind and you had to change it a little bit to make it compatible with windows Powershell. We shouldn't have two scripts. This is why adding a docker-compose.yml file is necessary.

pourmand1376 avatar Sep 11 '22 09:09 pourmand1376

This commit changes the command users should type if they want to use docker. I've understood that using docker-compose is pretty much standard and it works with all operating systems (specially Windows).

Note: we still keep previous commands for compatibility (For previous commands I mean ./bin/dockerhub_run.sh and etc. ). This is because some users are accustomed to using it this way. We shouldn't break their habit.

With this commit, we can use docker pre-built image using:

docker-compose up

we can build a custom image with:

docker-compose -f docker-local.yml build

and we can use locally built image using:

docker-compose -f docker-local.yml up

pourmand1376 avatar Sep 11 '22 14:09 pourmand1376

I added two parameters --verbose and --livereload. I have to see if those parameters add any problems here.

pourmand1376 avatar Sep 11 '22 15:09 pourmand1376

I have tested this commit in Windows, and it is working well. Any comments? @alshedivat @rohandebsarkar

pourmand1376 avatar Sep 17 '22 20:09 pourmand1376