Omar Alshaker

Results 79 comments of Omar Alshaker

> Are you saying that you will overwrite array's native shift? Not on the global scope. Only the proxified arrays will be affected. The user will not have to do...

@tomalec correct, I thought about it but I dug Polymer source and they use `yourArray.splice` 💃

> because that one often generates patches that remove objects from an array. Aha! Didn't know that, even though it's obvious now that I think about it. > This is...

Maybe try add a `setter` to the value property? ```js Object.defineProperty(yourEditor, 'value', { set(val) { yourEditor.setValue(val, 1) } }); ```

I agree with this comment https://github.com/Juicy/juicy-ace-editor/pull/45#issuecomment-393810839. I thought Infinity meant as large as the container can fit.

> I missed a lot of contextual conversation for this decision The reasoning behind this is to remove any interaction between steps. The biggest source of problems in /start is...

Trac ticket and fix are ready https://core.trac.wordpress.org/ticket/54308#ticket https://github.com/WordPress/wordpress-develop/pull/1774

Thanks a lot @escapemanuele and @renancarvalho! I addressed everything.

@renancarvalho regarding Happychat and The bridge. It seems you're proxied and your sandbox isn't up-to-date. Either disable sandboxing or `git pull` in your sandbox.