alsatian
alsatian copied to clipboard
alsatian-test
Initial commit of Webstorm support
Hi, this is my first version of the extension needed to have webswing support. This is only the typescript/javascript part. The IDE plugin itself (java) will be in an own git repository, and also made available to easy download via idea marketplace.
Hey @Gr33nbl00d, happy to review this for you if you would like.
I do have two concerns though:
- As a maintainer I don't use webstorm so would find it difficult to maintain this particular bit - happy to make you a maintainer as well though of this repo though if that's something you'd be interested in :)
- Does it make sense for your plugin to be split across multiple repositories? is it going to be difficult for you to maintain vs you having it all in one place that you control? - if the concern here is getting good visibility and promo for your plugin I'm happy to put up some links and promo for this plugin on the repo
Let me know your thoughts, thanks.
To 1) I am happy to support you wih my help. I just have to admit that the times i can invest will vary, based on my usual workload ;) To 2) Im not sure how this works with Visual Code in IDEA the main coding is done in Java. The interface between Typescript and Idea is really very low level. Only reporting of test execution state. I was not sure if it would be a good idea to put it into this repo because its totally different technologie. However if you think it makes more sense to put this code also somewhere here i can do.
Btw link to repo: https://github.com/Gr33nbl00d/alsatian-webstorm-plugin
Regarding the other 3 Code Climate findings. I could refactor it but i dont think it will increase readability
Link to the Plugin release page on jetbrains: https://plugins.jetbrains.com/plugin/15185-alsatian-test
Hey, sorry about the late response it's been a very busy one.
With respect to the code I think it's wonderful and have added a note to our readme linking to it as it's a great addition. (if you want any changes please let me know).
With respect to where the code should live I feel it makes sense that the Java and TypeScript are together as I would assume you need to deploy them together and my concern would be that if it was in this repo it'd make it difficult for you to maintain it. Unless I'm missing something here?
Great work :) let me know if you think I've missed something or you'd like some more signposting to your plugin
Ok so you mean its better to release this plugin as independent artifact? :)
Sorry for the late response end of year business is striking in :) I will release this extension as soon as i have some time as seperated project :) So i think you can close this merge request :)