alromeros comments

Results 106 comments of


                                            alromeros

New PR and commit guidelines

/remove-lifecycle rotten /retest-required

[release-v1.57] Improve http import flow to decide whether to use scratch space or not

A test fails because it expects 0 restarts in the DV but the scratch space requires a restart. Closing this to address it manually.

Address incompatibility between IOThreads and non-virtio buses

/retest

Address incompatibility between IOThreads and non-virtio buses

> Why cannot we set some defaults instead of rejecting? Even with defaults, if someone explicitly enables IOThreads with an incompatible disk I think it makes more sense to reject...

Address incompatibility between IOThreads and non-virtio buses

/retest-required

Address incompatibility between IOThreads and non-virtio buses

Thanks for the reviews! Opening backports: /cherry-pick release-1.2 /cherry-pick release-1.1

Address incompatibility between IOThreads and non-virtio buses

/cherry-pick release-1.1

Support annotations on StorageClass to ignore during StorageProfile reconciliation

@arnongilboa maybe https://github.com/kubevirt/containerized-data-importer/pull/3129 already addressed this issue?

Virtual image size is larger than the reported available storage

Maybe this case is similar to the one described here https://issues.redhat.com/browse/CNV-36769? If a first upload attempt failed for some unrelated reason (maybe the upload pod was force-deleted), then in subsequent...