alpine-make-vm-image icon indicating copy to clipboard operation
alpine-make-vm-image copied to clipboard

If target image is a block device, access it directly

Open omnivagant opened this issue 3 years ago • 3 comments

This will allow a user to specify a block device, like an LVM volume or ZFS zvol, as target.

omnivagant avatar Apr 01 '21 22:04 omnivagant

This is a nice idea, but it’s incomplete – cleanup function (alpine-make-vm-image:143-146) must be modified.

jirutka avatar Nov 26 '21 00:11 jirutka

Like so?

In some sense I feel like I'm a bit lazy here in keeping the $nbd_dev name even if it isn't.

omnivagant avatar Nov 27 '21 13:11 omnivagant

Yes, there are more things that should be renamed and documented to make sense after this change.

jirutka avatar Jul 14 '22 20:07 jirutka

What if we just call it $disk_dev instead, would that be enough?

omnivagant avatar Sep 23 '23 23:09 omnivagant

Yes, that’s fine, but the help message needs to be updated as well.

jirutka avatar Sep 24 '23 00:09 jirutka

Of course, like so?

omnivagant avatar Sep 25 '23 09:09 omnivagant

Yes, thanks!

jirutka avatar Sep 29 '23 13:09 jirutka