alpine-chroot-install icon indicating copy to clipboard operation
alpine-chroot-install copied to clipboard

Speedup and fix umount

Open douglas-raillard-arm opened this issue 2 years ago • 2 comments

closes https://github.com/alpinelinux/alpine-chroot-install/issues/30 and https://github.com/alpinelinux/alpine-chroot-install/issues/31

douglas-raillard-arm avatar Oct 12 '21 15:10 douglas-raillard-arm

I merged the second commit, “Fix umount”, as 8f12e62621db8b7fdd226bca69b8d7f0403140ee. Thanks!

I don’t have time to review the first one right now, I’ll come back to it later.

jirutka avatar Mar 09 '22 16:03 jirutka

Thanks, that was the most important one anyway. Since that PR I switched to a simple chroot based on the official minirootfs so I don't really need the speed boost anymore.

Doing something simiar for alpine-chroot-install would also fix that https://github.com/alpinelinux/alpine-chroot-install/issues/27 and AFAICT it does not need some key setup shenanigan.

douglas-raillard-arm avatar Mar 10 '22 11:03 douglas-raillard-arm