terragrunt icon indicating copy to clipboard operation
terragrunt copied to clipboard

Remove Dockerfile templating in main build

Open JulianCBC opened this issue 2 years ago • 2 comments

Build args can be used to specify the version of containers in FROM lines, so skip a step in the build process by passing the Terraform version in as an argument instead of templating the Dockerfile.

I haven't done the same conversion to the EKS image as it doesn't build at present.

This conflicts with #27 so I'll sort that out once one of these is merged.

JulianCBC avatar Oct 25 '23 01:10 JulianCBC

Thanks for your PR. let's hold this change, until we plan to put OpenTofu (need be GA release) in it.

The existing tag could be terraform version, since no conflict.

ozbillwang avatar Oct 25 '23 02:10 ozbillwang

I don't understand, this isn't changing the tags, this is just some cleanup.

JulianCBC avatar Oct 25 '23 02:10 JulianCBC

@JulianCBC

Looks fine to me now.

But there are some new PRs merged recently, could you resolve the conflicts?

ozbillwang avatar May 22 '24 13:05 ozbillwang

TODO list:

  • add opentofu binary in this image
  • define new tags
  • No latest tag any more.
  • rollback the new tags we merged last time (1, 1.8)

New tags for discussion

  • alpine/terragrunt:tf1.8.3
  • alpine/terragrunt:otf1.7.1 or alpine/terragrunt:ot1.7.1

ozbillwang avatar May 22 '24 13:05 ozbillwang

  • alpine/terragrunt:otf1.7.1 or alpine/terragrunt:ot1.7.1

"tf" is TerraForm, i.e. letter per syllable, so "otf" being OpenToFu also makes sense.

JulianCBC avatar May 23 '24 00:05 JulianCBC

I've rebased this over the latest changes in master. Let's handle that TODO list in separate pull requests.

JulianCBC avatar May 23 '24 00:05 JulianCBC

TODO list:

  • add opentofu binary in this image
  • define new tags
  • No latest tag any more.
  • rollback the new tags we merged last time (1, 1.8)

New tags for discussion

  • alpine/terragrunt:tf1.8.3
  • alpine/terragrunt:otf1.7.1 or alpine/terragrunt:ot1.7.1

opentofu has been installed in the latest image now.

docker run -ti --rm alpine/terragrunt tofu --version
OpenTofu v1.7.1
on linux_amd64

For examples, below tags are supported now:

  • alpine/terragrunt:latest
  • alpine/terragrunt:1.8.4 (terraform version)
  • alpine/terragrunt:tf1.8.4 (terraform version)
  • alpine/terragrunt:otf1.7.1 (opentofu version)

ozbillwang avatar May 24 '24 05:05 ozbillwang