alphapapa
bug: make sure color attributes are specified in prism-blend
I hit a nasty bug here because my foreground was unspecified when prism-comments-fn was called. I tried to follow the example of ‘color-values’ to decide how to handle that generally for custom color functions.
Hm, I hit a similar issue in another package, and the solution IIRC was to specify the default face as a final argument to face-attribute, because according to the Elisp manual, that face is supposed to always be fully specified.
Hey, sorry for the delay, I got busy with some things and forgot about this.
Hm, I hit a similar issue in another package, and the solution IIRC was to specify the
defaultface as a final argument toface-attribute, because according to the Elisp manual, that face is supposed to always be fully specified.
Oo, yes, it should be-- and in this case(I'm using https://github.com/dracula/emacs) it seems it is, but it's inheriting it from shadow. The face-attribute function for some reason does not pick up inherited attributes by default(performance? I really dunno). I'll open another PR with that change.
As for this PR, I think that blend function could very well be upstreamed to the colors library. Since it's doing the same type of operation as those functions, I think it only makes sense to follow their example and handle unspecified attributes.