pocket-reader.el icon indicating copy to clipboard operation
pocket-reader.el copied to clipboard

Bug: `pocket-reader-{add,remove}-tags` do not support space-containing tags

Open pataquets opened this issue 2 years ago • 4 comments

If you want to add/remove a tag named view online, it won't work. Trying to set such tags acts weird: sometimes the pocket buffer closes, others the entry disappears (could not reproduce a fixed case). I've successfully quick-fixed the add & remove functions by removing the space keyword from the s-split call in their respective functions. I'm not sure if it's good enough. although it works when removing one tag and when removing several comma-separated tags. I can send this as a PR or, if it's inside my abilities, some easy changes which might be needed.

Related: #43

pataquets avatar Sep 04 '23 17:09 pataquets

Thanks. As you can probably tell, I don't use this package often anymore, so I haven't noticed a lot of these things.

alphapapa avatar Sep 04 '23 19:09 alphapapa

I didn't noticed it, as you're maintaining it in an awesome fashion. In case you're feeling burdened by maintenance and, since you're no longer using it, I suggest you to consider appointing some co-maintainer to alleviate your burden. Just posting a "[co-]maintainer wanted" kind of issue might be a good way to gauge interest. Since user base is quite decent, I guess you'll get some interested users. Just a suggestion to help you stay sane :smile:. Thanks for your awesome work.

pataquets avatar Sep 05 '23 00:09 pataquets

Thanks for the kind words. I'm glad it's useful to you.

Finding a co-maintainer is usually tricky. Users don't generally look at the repository unless they need to report a problem, and most of them aren't also developers. Then of those that are, the portion that also have similar style is an even smaller number. And of those, the ones who would want to take on the role... well, the number quickly approaches 0. :)

Usually it starts by a user contributing a few high-quality patches, showing that they are capable and interested, and can be trusted to commit changes without much oversight. If that happens, then taking on the role can happen somewhat naturally. But then the issue tends to be that the new co-maintainer may not maintain his interest or free-time for very long. Unless I were to turn the package over for "adoption" by someone else as the primary maintainer, it ultimately falls back to me. That's just the way FLOSS development tends to work.

alphapapa avatar Sep 05 '23 01:09 alphapapa

In case you need it in the future and didn't know about it, there's Adoptoposs (see blog post).

pataquets avatar Sep 05 '23 01:09 pataquets