alphapapa
Problem when URL mentioned in pocket-reader-domain-url-type-map is undefined
I am using pocket-reader-domain-url-type-map for theguardian.com to use the resolved_url, the same as the reddit example in the default config: https://github.com/alphapapa/pocket-reader.el/blob/master/pocket-reader.el#L217-L219
Sometimes this value seems to be undefined, which leads to pocket-reader being completely blocked. For now I removed my customization again, but it would be good if there would be a fall-back to given_url which should always be available.
It just stops and ins not responsive to keys. I guess another fix would be to catch the error and skip that entry, but that could be confusing because the user would never notice.
It just stops and ins not responsive to keys.
How long did you wait? What happens if you C-g? What do you see in *Messages*? For that matter, what key did you press that caused it to block? You're not giving me enough information.
Anyway, if Emacs seems blocked, it's probably waiting on a network request, which isn't necessarily a bug in this package.
I am going to try to reproduce it. I tried fixing it myself when it happened, but my emacs skills were not quite up to it. I removed the offending link in Pocket and then figured out that changing the configuration also worked.
Issue gardening. @christofdamian Did you manage to reproduce the issue? Can this be closed?
I ended up redefining the priorities, which avoids the problem.
(pocket-reader-url-priorities '(resolved_url given_url amp_url))
I'd like to fix this, if anything needs to be fixed here, but I don't seem to have enough information. Please chime in if this still happens.