org-make-toc icon indicating copy to clipboard operation
org-make-toc copied to clipboard

Add option to make links work in both Github and Emacs org mode by inserting Custom Id property

Open hemanta212 opened this issue 3 years ago • 4 comments

Hi, If a custom id is inserted into the property drawer in each heading. The links will work in Org-mode. So it might be desirable for some users to get this behaviour where the tool inserts the CUSTOM ID property in each heading. Any thoughts on this?

For my use case I generally have a lot of properties customization inside my headings already so one line of CUSTOM ID won't hurt instead of me manually having to put it in each heading.

hemanta212 avatar Jan 21 '22 17:01 hemanta212

Hi,

I haven't tested that solution, but if it works, I've no objection to supporting it in this package. I'm not sure if I would use it, so I don't know if I'd code it myself anytime soon.

alphapapa avatar Mar 01 '22 10:03 alphapapa

@hemanta212 Custom id links won't work on github, will they?

noctuid avatar May 06 '22 12:05 noctuid

@noctuid Custom id links implementation is addition on top of existing way, With current way we have support for github but not org mode. Adding custom id links will enable the links to work on org mode. Thus, supporting both github and org-mode.

hemanta212 avatar May 08 '22 02:05 hemanta212

Ah, I was thinking of UUID/normal ID links. This approach seems to work fine. I opened a PR.

noctuid avatar May 08 '22 12:05 noctuid

Finally merged. Please let me know if it works for you. Thanks.

alphapapa avatar Sep 04 '23 09:09 alphapapa

Can confirm, it works great!, Thank you so much @alphapapa and @noctuid 🙏

hemanta212 avatar Sep 06 '23 12:09 hemanta212

@hemanta212 Thanks.

alphapapa avatar Sep 06 '23 12:09 alphapapa