org-make-toc icon indicating copy to clipboard operation
org-make-toc copied to clipboard

Published 20 hours ago • verified publisher icon alphapapa

Fix: more forgiving drawer regexps

Open progfolio opened this issue 4 years ago • 6 comments

Abstract regexp for beginning of :CONTENTS: drawers into a variable. Allow whitespace before :CONTENTS: and :END: drawer markers.

Ran into the "No TOC node found" user-error despite having a :CONTENTS: drawer. This pull relaxes the regexps for drawer delimiters to allow for space between bol and the delimiter. More closely matches org-clock-drawer-end-re.

Thanks again for the package!

progfolio avatar Sep 19 '20 14:09 progfolio

Thanks. We could use a defconst for the regexp, since it isn't intended to be changed.

alphapapa avatar Nov 26 '20 21:11 alphapapa

Good catch. Taken care of.

progfolio avatar Nov 26 '20 22:11 progfolio

Tidying up things on my end. Closing this issue, but feel free to use the patch if you like.

progfolio avatar Sep 24 '22 19:09 progfolio

@progfolio Please don't close PRs that haven't been handled yet.

alphapapa avatar Sep 25 '22 13:09 alphapapa

Please don't close PRs that haven't been handled yet.

Noted. I don't use the package any more, so the patch is offered "as is". I've unsubscribed from notifications for this pull so that you can keep it open.

progfolio avatar Sep 25 '22 17:09 progfolio

Thanks.

alphapapa avatar Sep 26 '22 14:09 alphapapa

@alphapapa is this good to merge? I bumped into this error yesterday.

mpereira avatar Jun 15 '23 10:06 mpereira

@progfolio Thanks for fixing this and for your patience.

@mpereira Thanks for the reminder and your patience.

alphapapa avatar Sep 04 '23 08:09 alphapapa

@alphapapa thank you for the time you put into your many packages and for sharing them with us 🙂

mpereira avatar Sep 04 '23 16:09 mpereira