magit-todos icon indicating copy to clipboard operation
magit-todos copied to clipboard

Not working in 25.2

Open seagle0128 opened this issue 4 years ago • 5 comments

In Emacs 25.2.2, I got this error. Should use -when-let* or drop 25.x.

Symbol's function definition is void: when-let*

seagle0128 avatar Feb 20 '20 06:02 seagle0128

Thanks. How did you notice this? Are you still using Emacs 25.2 personally? Which solution do you think I should use?

alphapapa avatar Feb 20 '20 10:02 alphapapa

I have a testing env and 25.2.2 is installed by default. I notice magit-todos supports 25.1+. Regarding such compatibility issues, I suggest to use dash, or defalias like this.

(unless (fboundp 'when-let*) (defalias 'when-let* #'when-let))

seagle0128 avatar Feb 20 '20 16:02 seagle0128

@alphapapa @seagle0128

Package is also not working for some repositories while it's working for .emacs.d repo.

I have a repository with yaml files and magit-todos-mode does not show up in magit-status-buffer . I get a empty buffer if I run magit-todos-list. When I run ivy-magit-todos i get nice failed in mini-buffer .

I have installed libnice with homebrew.

This is how I have it in yaml file image

I am using centaur-emacs configuration with emacs 26.3 on macos.

CsBigDataHub avatar Apr 07 '20 15:04 CsBigDataHub

@CsBigDataHub Why did you post under this issue? This issue about Emacs 25.2, which you are not using.

alphapapa avatar Apr 07 '20 16:04 alphapapa

@CsBigDataHub Why did you post under this issue? This issue about Emacs 25.2, which you are not using.

@alphapapa , I thought this was relevant here. I am creating a new new issue?

CsBigDataHub avatar Apr 07 '20 18:04 CsBigDataHub

v1.6 of magit-todos requires Emacs 26.1 or later, so closing this. Thanks for reporting, though.

alphapapa avatar Mar 07 '23 05:03 alphapapa