magit-todos icon indicating copy to clipboard operation
magit-todos copied to clipboard

Add tip on how to start the mode automatically.

Open Kaligule opened this issue 2 years ago • 5 comments

Kaligule avatar May 27 '22 08:05 Kaligule

Seems like a good idea, thanks.

alphapapa avatar Aug 15 '22 21:08 alphapapa

It seems like you forgot to merge it. Or did I miss something?

Kaligule avatar Sep 16 '22 04:09 Kaligule

IIRC, it seemed like further reflection was needed. I'm not sure that activating with magit-mode-hook makes sense, because that mode is activated every time a magit- buffer is initialized, and the initialization done with magit-todos-mode only needs to be done once. I think that simply doing (magit-todos-mode) is all that's necessary.

Also, why is that line in the readme changed?

Thanks.

alphapapa avatar Sep 17 '22 16:09 alphapapa

Having (magit-todos-mode) in my config didn't work for me I think. It seemed to me that magit has already to be running when magit-todos-mode is started. Thats why I used the hook.

Also, why is that line in the readme changed?

Which line do you mean?

Kaligule avatar Sep 23 '22 07:09 Kaligule

Having (magit-todos-mode) in my config didn't work for me I think. It seemed to me that magit has already to be running when magit-todos-mode is started. Thats why I used the hook.

To get to the bottom of this, we'll have to be more specific. Please try to reproduce the problem in a clean Emacs config, e.g. using https://github.com/alphapapa/with-emacs.sh (Aside: This is why I generally recommend filing an issue describing a problem before sending a PR that seems to fix something. We should identify a problem before proposing a change. And if we make a change that seems to fix something in your personal config, it may break other users' configs.)

Also, why is that line in the readme changed?

Which line do you mean?

The one that changes the description of the link to the TRAMP usage notes.

alphapapa avatar Sep 23 '22 19:09 alphapapa