alphapapa
Reset timestamp faces when theme changes
The automatic generation of faces for the time column is pretty sweet, but if I toggle between light and dark themes, the faces don't get updated. I could presumably add something to modus-themes-after-load-theme-hook in my case, but I'd need a function to call which can do that.
For now the workaround is closing the rooms list buffer and reopening it, so it's not high priority, but I figured I'd put the request in.
Looking at the code, this should be relatively simple to move out to a separate function. I might take a shot at it later.
I've thought about changing this, but since the workaround is so simple, I haven't bothered.
As well, I've actually found it helpful that this doesn't happen automatically: When I start Emacs using the theme doom-solarized-light and open the room list buffer, the timestamp faces are colorized from yellow-to-default, and then I can change to a theme for which the warning face is the same color as default, like modus-vivendi, while keeping the yellow timestamps.
Anyway, if you want to factor it out so you can do it automatically, that's fine with me.
BTW, any update on the FSF CA? Even a change this simple would be more than 15 lines, and I'd still like to aim for GNU ELPA, so...
Yeah, I might refactor it also because I've been working on copying ement-room-list for an ement-device-list and I kinda want to do the same trick there, so maybe there could be generic timestamp faces that both lists could use and one function to generate them.
I've contacted the FSF and sent back their initial form and am waiting to hear back from that. I've verified with my company that they've got no issues with my contributing to FOSS in my free time so I don't anticipate any roadblocks once they come back to me with whatever forms.
@treed Time sure has flown. :) Any update on the FSF CA process? (Or did you already do it? ISTR but forget...) I'd still be glad for you to contribute this change.