dogears.el icon indicating copy to clipboard operation
dogears.el copied to clipboard

Possibly bugs in `dogears-go` and `dogears-forward`?

Open all9n opened this issue 2 years ago • 1 comments

First of all, thanks for the package!

I see 2 places that might be bugs. (Disclaimer: relatively new to Emacs and don't understand how bookmarks work.)

  • In dogears-forward, it seems (nth -1000 '(a b c)) returns a, so dogears-index could go negative?
  • In dogears-go, (bookmark-jump place) returns nil after jumping (at least for me) so the or below is kind of pointless. https://github.com/alphapapa/dogears.el/blob/c05b69e504a538c9e00fbb0ea86934fafe191d0c/dogears.el#L234-L236

all9n avatar Jul 23 '22 19:07 all9n

Thanks. I'll fix this when I get a chance.

alphapapa avatar Sep 29 '22 18:09 alphapapa

i put up a pr for the former: https://github.com/alphapapa/dogears.el/pull/19

gitrj95 avatar Feb 28 '23 16:02 gitrj95

@all9n This should be fixed by the changes in v0.2-pre. Thanks.

alphapapa avatar Jun 10 '23 16:06 alphapapa