Adam Porter

Results 2642 comments of Adam Porter

> That sounds like the next step, then. > > How about we keep this PR on the back-burner, and I can follow up down the track if I think...

> I see it's possible for the prompt to come up as "Ban user nil ...?", so I should account for them not having a display name. We should probably...

By the way, I think we should add support for reporting messages to the homeserver admin. In Element, when I'm deleting spam, my procedure is usually: 1. Report to homeserver...

I appreciate your thoughtfulness, but I think we should just do what Element does here. If the official client doesn't care about offering a way to set the score parameter,...

@phil-s Thanks for your work and your patience. I pushed some "Minor changes" and rebased. Let me know if you agree that this is ready to merge.

> Fair enough ditching the completing-read for score. I knew that seemed slightly mad by default, but I'd kept it so that users could change the list of options to...

> I'd figured everything not labelled **Required** was optional? Well, I guess you're right. :) Would you mind testing to see what happens if we send a request without the...

Thanks, we definitely need some kind of "do all the things" combo command. I think it'd be best to follow Element's lead here, i.e. when banning a user, maybe a...

Yeah, I like that idea. (Not expecting you to code it, necessarily, but feel free to if you are interested.)

Hi @phil-s, I rebased on current master and then pushed https://github.com/alphapapa/ement.el/commit/8b853d852c73e732ce95b5491e475a9aaf97b115. Please let me know what you think about that. If you concur, then I think we should go ahead...