Adam Porter
Adam Porter
Hi @vizs, I pushed another commit to your branch that makes some minor changes. It also adds two FIXMEs that should probably be addressed before merging. Please review my changes...
@vizs Thanks. Did you see the two FIXME comments? How do you think we should handle them? Also, do you know of a good way to test this new code?...
> (Did my "review comments" not go through?) I can't find any. Maybe you forgot to press the "Finish review" button. I've done that before, because the UI is non-obvious...
Thanks, I agree with those solutions. One more thing: I think we should have an option to make Ement send rich replies too. Would you be interested in adding that...
@vizs I rebased this branch onto master and pushed some small changes on top, including linting with `makem.sh` again. Please review the new commits I pushed and the current diff...
> I simply cannot recall why I added the `when', if you want we can drop it and add it back when someone (TM) complains. AFAIK, if this function is...
@vizs Ok, thanks. I pushed another commit doing that. However, before merging this, I looked at the spec again: https://spec.matrix.org/v1.3/client-server-api/#rich-replies IIUC, to support it correctly, we also need to: -...
Ok, let's defer this to v0.13. Since it seems that other clients are either not using rich replies or are always including the inline fallbacks, it doesn't seem urgent to...
No problem. You've already done valuable work on this. There's no urgency to finishing it. I'll plan to finish it myself when I get time, or maybe you'll change your...
0.14 is shaping up, so I'll plan to merge and test this for 0.15.