Adam Porter comments

Results 2645 comments of


                                            Adam Porter

Keyword matching is not respecting Git ignore rules even with `rg` installed

Hello David, I cannot reproduce this problem. Is the `rg` scanner being detected and used by `magit-todos`?

Keyword matching is not respecting Git ignore rules even with `rg` installed

Check the value of `magit-todos-scanner`.

Disable automatic scans in remote repositories, add option to re-renable

Hi again, Thanks, this seems like a good idea. Will target for v1.8.

Disable automatic scans in remote repositories, add option to re-renable

Having heard from another user today who had problems with misbehavior over TRAMP, I suspect that this new option should probably be disabled by default. What do you think?

Disable automatic scans in remote repositories, add option to re-renable

@projectgus Seems like a good idea to me. Thanks.

Disable automatic scans in remote repositories, add option to re-renable

I appreciate your patience, as the past few weeks have been very busy for me. Regarding this PR, I'm not especially happy with the size of the diff, caused by...

Disable automatic scans in remote repositories, add option to re-renable

> Hi @alphapapa, > > Thanks for the review comments, and absolutely no problem with being busy. I fully support you not looking at this PR again until you have...

Disable automatic scans in remote repositories, add option to re-renable

Merged with a few small changes in additional commits. Thanks, Angus!

Idea: use (magit-get-upstream-ref) as ref commit

I don't know. From what I can tell in its docstring, `magit-get-upstream-ref` doesn't do quite the same thing. I can imagine that it might be useful or preferred in some...

Idea: use (magit-get-upstream-ref) as ref commit

You were clear, and I understood what you meant. It seems that you didn't quite understand my reply. Did you read carefully the docstring I quoted? As I said, it...