Adam Porter

Results 2645 comments of Adam Porter

Hi Grant, Thanks. Could you enable `debug-on-error` and show me the backtrace when it happens again? Also, what build of Emacs do you have installed, i.e. from where?

Thanks. Does that room have an avatar? If so, does it appear properly in other clients?

Please check the line wrapping in the diff, and please provide some commentary or discussion outside of the diff.

Again, please check the line wrapping. The original source is not line-wrapped, so nor should the patch be. And, again, please provide commentary in the commit message explaining the purpose...

> Doing this is significantly more resource demanding You weren't kidding! :) I'm sorry to report that this is probably not usable in its current state. I loaded my main...

BTW, I understand basically why you do this, but I think it's inappropriate to do so when the file is loaded, as that's out of the package's scope: ```el (put...

Also, it seems bogus to be running this on every movement command: ```el (defun focus-get-thing () "Return the current thing, based on `focus-mode-to-thing'." (or focus-current-thing (let* ((modes (mapcar 'car focus-mode-to-thing))...

BTW, I'm noticing some--what seems to me like--strange behavior with `focus-mode` enabled (and this in `emacs -q` with only Focus loaded): * Edebug isn't usable to step through code. e.g....

> Thank you @alphapapa! I'm glad I held off on merging. A full second is not an acceptable amount of lag. In the most recent version ([9af4fbe](https://github.com/larstvei/Focus/commit/9af4fbe6359eba7958d697e8d9036760f86c87d3)) the lag was...

`(declare (indent defun))` is usually the solution.