activities.el icon indicating copy to clipboard operation
activities.el copied to clipboard

Store activities bookmarks on save

Open jdtsmith opened this issue 1 year ago • 4 comments

Store each activity bookmark whenever it is saved. This handles cases in which activities-bookmark-store was turned on after an activity was defined, or the bookmark was deleted.

jdtsmith avatar Oct 25 '24 00:10 jdtsmith

Hi JD,

Yeah, I guess this is the right thing to do. My only hesitation is that it may cause the bookmark file to be saved more frequently, which is mostly only a potential problem in light of the message showing up in the minibuffer, haha.

What do you think? Thanks.

alphapapa avatar Oct 25 '24 01:10 alphapapa

Added a check for an existing bookmark with that name, so we store on save only if it doesn't yet exist.

jdtsmith avatar Oct 25 '24 16:10 jdtsmith

Thanks. Does that need to be an option, or could we make that behavior unconditional?

alphapapa avatar Oct 25 '24 22:10 alphapapa

Sorry just saw this. In the current setup for this PR, when creating a new activity (via activities-define), you can re-use an old bookmark name and it will overwrite the (vestigial) bookmark with new properties immediately. This seems like a good thing to have, especially until bookmark removal on activity deletion is implemented.

jdtsmith avatar Dec 23 '24 22:12 jdtsmith