nest_transact icon indicating copy to clipboard operation
nest_transact copied to clipboard

Published 20 hours ago • verified publisher icon alphamikle

Is it possible to back port the "null dependency" fix (PR #14) into `v8.0.0`

Open maxpeterson opened this issue 2 years ago • 2 comments

Thanks for providing this library.

I have a project that I can not yet upgrade to v9.0.1 and I am blocked using the v8.0.0 dues to the "null dependency" issue fixed by #14.

Is it possible to back port the fix and publish it as v8.0.1?

If you create a branch v8.0.x branch (from the v8.0.0 tag) I could create a PR with the fix (from #14) for you to check and publish from the v8.0.x branch).

FYI: The issue occurs when I use @Inject('SOME_STRING') someThing: SomeClass. In this case the param is a string that is not canBeRepository so dependency is never set.

maxpeterson avatar Oct 28 '22 09:10 maxpeterson

Hi @maxpeterson! Sorry for the long answer. I will do it on next weekend

alphamikle avatar Jan 12 '23 14:01 alphamikle

@maxpeterson hi! Well... it took a little more time for me, sorry, but I've, finally, created the required branch and you can do, what you would like to do.

alphamikle avatar Feb 06 '23 17:02 alphamikle