AlphaFS icon indicating copy to clipboard operation
AlphaFS copied to clipboard

PhysicalDiskInfo class #455

Open Yomodo opened this issue 7 years ago • 2 comments

Hi @alphaleonis, I'd appreciate a review on this one, for a v2.3. I think it's ready to go.

Yomodo avatar Jun 20 '18 20:06 Yomodo

Hm yeah, perhaps a bit too much for a simple "review", and perhaps not the best word for it.

The majority of the commits are all about the Device.PhysicalDiskInfo class and related members, a new addition to AlphaFS, and not so much about radically changing the existing base code, other than splitting files/methods.

So the review is not about comparing existing base code that has been improved, but more of an approval for this new AlphaFS member.

PhysicalDiskInfo role is to kind of act like a DiskInfo, but aimed at, well, physical disks. The issues you pointed out is exactly what I mean.

Yomodo avatar Sep 01 '18 21:09 Yomodo

Alright, I'll have another look at the PhysicalDiskInfo class shortly then and get back to you. :)

alphaleonis avatar Sep 02 '18 15:09 alphaleonis