whitehall icon indicating copy to clipboard operation
whitehall copied to clipboard

Bump govuk_sidekiq from 8.0.1 to 9.0.1

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps govuk_sidekiq from 8.0.1 to 9.0.1.

Changelog

Sourced from govuk_sidekiq's changelog.

9.0.1

  • Allow setting of Redis SSL verify_mode to none via environment variable

9.0.0

  • Switch from using redis gem to redis-client
  • BREAKING: Remove redis-namespace dependency and support for Redis namespaces
    • Run the redis_namespace:remove_namespace rake task immediately after upgrading to to this version, to retain existing queued jobs.
  • BREAKING: Upgrade Sidekiq to version 7.0, follow these steps to upgrade:
    1. Sidekiq::Worker has been deprecated in Sidekiq 7. Replace all instances of Sidekiq::Worker with Sidekiq::Job, then rename/move your workers to be app/sidekiq/MyJob.rb instead of app/workers/MyWorker.rb.
    2. Remove the requirement for Sidekiq strict arguments from config/initializers/sidekiq.rb. This was added to include Sidekiq 7 strict arguments behaviour in Sidekiq 6, but is no longer needed to be explictly required, since this is now the default behaviour.
    3. If using sidekiq-unique-jobs, pin to < 8.0.8 until a known issue is resolved.
    4. Make any changes required based on the information in the Sidekiq 7 API migration guide.
Commits
  • d539ff5 Merge pull request #118 from alphagov/release-9.0.1
  • 8fe4883 Release version 9.0.1
  • 780b80e Merge pull request #117 from alphagov/redis-ssl-params
  • 27c60b5 Allow setting Redis SSL verify_mode via env var
  • 2b0b846 Merge pull request #116 from alphagov/autorelease
  • 94b17e5 Add autorelease workflow
  • 946dd53 Merge pull request #115 from alphagov/sidekiq-mobbing
  • 289da44 Release version 9.0.0 of the gem
  • 749f82b Add rake task to remove Redis namespacing
  • a89c0b9 Add upgrade instructions for Sidekiq 7
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Oct 08 '24 09:10 dependabot[bot]

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

github-actions[bot] avatar Oct 08 '24 09:10 github-actions[bot]

Leaving a few comments for further debugging:

  • we seem to still have redis as a dependency in the lock file
  • unclear on the redis_namespace:remove_namespace run
  • most tests pass locally (except for request_tracing_test.rb)
  • CI run failed with 19, 107, and 56 failures respectively, on subsequent runs
  • The failure error is smth we typically see when we're missing a mock for asset manager calls, usually needed for expectation around the asset creation worker. The worker normally doesn't execute unless we drain it specifically or run the code in an Sidekiq::Testing.inline! block. My guess would be that something has changed in sidekiq OR we need to check some WH config to make sure how we set it up previously still works OR it might have to do with the fact that you have not migrated the workers to the new path. (See review comment @GDSNewt )

lauraghiorghisor-tw avatar Nov 08 '24 13:11 lauraghiorghisor-tw