whitehall
whitehall copied to clipboard
Bump govuk_sidekiq from 8.0.1 to 9.0.1
Bumps govuk_sidekiq from 8.0.1 to 9.0.1.
Changelog
Sourced from govuk_sidekiq's changelog.
9.0.1
- Allow setting of Redis SSL
verify_modeto none via environment variable9.0.0
- Switch from using
redisgem toredis-client- BREAKING: Remove
redis-namespacedependency and support for Redis namespaces
- Run the
redis_namespace:remove_namespacerake task immediately after upgrading to to this version, to retain existing queued jobs.- BREAKING: Upgrade Sidekiq to version 7.0, follow these steps to upgrade:
Sidekiq::Workerhas been deprecated in Sidekiq 7. Replace all instances ofSidekiq::WorkerwithSidekiq::Job, then rename/move your workers to beapp/sidekiq/MyJob.rbinstead ofapp/workers/MyWorker.rb.- Remove the requirement for Sidekiq strict arguments from
config/initializers/sidekiq.rb. This was added to include Sidekiq 7 strict arguments behaviour in Sidekiq 6, but is no longer needed to be explictly required, since this is now the default behaviour.- If using
sidekiq-unique-jobs, pin to < 8.0.8 until a known issue is resolved.- Make any changes required based on the information in the Sidekiq 7 API migration guide.
Commits
d539ff5Merge pull request #118 from alphagov/release-9.0.18fe4883Release version 9.0.1780b80eMerge pull request #117 from alphagov/redis-ssl-params27c60b5Allow setting Redis SSL verify_mode via env var2b0b846Merge pull request #116 from alphagov/autorelease94b17e5Add autorelease workflow946dd53Merge pull request #115 from alphagov/sidekiq-mobbing289da44Release version 9.0.0 of the gem749f82bAdd rake task to remove Redis namespacinga89c0b9Add upgrade instructions for Sidekiq 7- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️
Follow these steps if you are doing a Rails upgrade.
Leaving a few comments for further debugging:
- we seem to still have redis as a dependency in the lock file
- unclear on the
redis_namespace:remove_namespacerun - most tests pass locally (except for
request_tracing_test.rb) - CI run failed with 19, 107, and 56 failures respectively, on subsequent runs
- The failure error is smth we typically see when we're missing a mock for asset manager calls, usually needed for expectation around the asset creation worker. The worker normally doesn't execute unless we drain it specifically or run the code in an
Sidekiq::Testing.inline!block. My guess would be that something has changed in sidekiq OR we need to check some WH config to make sure how we set it up previously still works OR it might have to do with the fact that you have not migrated the workers to the new path. (See review comment @GDSNewt )