whitehall icon indicating copy to clipboard operation
whitehall copied to clipboard

Port in accessible autocomplete from content publisher

Open DilwoarH opened this issue 2 years ago • 3 comments

This PR ports in accessible autocomplete from the content publisher

Preview: http://whitehall-admin.dev.gov.uk/component-guide/autocomplete

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

DilwoarH avatar Aug 11 '22 12:08 DilwoarH

Is it worth considering putting this into the gem instead?

andysellick avatar Aug 15 '22 08:08 andysellick

Is it worth considering putting this into the gem instead?

I'd like to do so but not this version, this version isn't well supported. This one: https://github.com/alphagov/accessible-autocomplete - is worth putting into the GEM

DilwoarH avatar Aug 17 '22 14:08 DilwoarH

In terms of actual components, there's also this one in smart answers, which is a very trimmed down simpler version, again based on the same original code: https://github.com/alphagov/smart-answers/blob/main/app/views/components/_autocomplete.html.erb

andysellick avatar Aug 17 '22 15:08 andysellick

In terms of actual components, there's also this one in smart answers, which is a very trimmed down simpler version, again based on the same original code: https://github.com/alphagov/smart-answers/blob/main/app/views/components/_autocomplete.html.erb

That's interesting (didn't know this), I'll work on getting these into the components gem

DilwoarH avatar Aug 24 '22 15:08 DilwoarH