publishing-api icon indicating copy to clipboard operation
publishing-api copied to clipboard

Fix conditional, I think

Open mike3985 opened this issue 1 month ago • 0 comments

Am I missing something or was the first of these two lines doing nothing? It looks like it was introduced in this big refactor https://github.com/alphagov/publishing-api/commit/c6ea837b6515b2ef4400e00f3400670c6076a17f, but that hasn't helped clarify things for me.

I don't think this changes the behaviour of the method, but does allow an earlier exit if the first, presumably quicker, check passes. So I'm assuming this was the intention..?

mike3985 avatar Nov 11 '25 15:11 mike3985