notifications-net-client icon indicating copy to clipboard operation
notifications-net-client copied to clipboard
verified publisher icon alphagov

probleme with the constructor of NotificationClient.cs and the http client used / configured

Open eccc-fp opened this issue 1 year ago • 1 comments

there is no constructor for NotificationClient.cs that accept an IHttpClient if the baseUrl is not the default one, DI cannot be properly used there

which cause another issue, the HttpClientWrapper.cs doesnt follow proper Guidelines for using HttpClient

which can cause a wide variety of issues and also it is not possible to implement a proper retry pattern

eccc-fp avatar Oct 17 '24 12:10 eccc-fp

Hi, if you're able to open a PR with an additional constructor to fix this that would be great. Otherwise it may be a few days before we are able to lend some developer time to a fix.

rparke avatar Oct 18 '24 09:10 rparke