notifications-api icon indicating copy to clipboard operation
notifications-api copied to clipboard
verified publisher icon alphagov

add db session bulk version to healthcheck endpoint

Open spatel033 opened this issue 1 month ago • 4 comments

Include alembic version from master and bulk db. Added db_version and db_bulk_version using get_db_version(session=db.session) and get_db_version(session=db.session_bulk) respectively. See this card for the more details. This PR will be deployed after aws-terraform and notify-api changes.

spatel033 avatar Nov 10 '25 18:11 spatel033

Only thing I don't understand about this PR is the use of the word "fixture" in the commit message etc.

risicle avatar Nov 25 '25 13:11 risicle

Only thing I don't understand about this PR is the use of the word "fixture" in the commit message etc.

Updated the commit message

spatel033 avatar Nov 25 '25 13:11 spatel033

🤔 I'm wondering if we should wrap the call to the bulk db in a try-block so that a connection failure wouldn't cause the status endpoint to fail, which would result in the instance being torn down.

risicle avatar Nov 25 '25 14:11 risicle

What do you think of this?

risicle avatar Nov 26 '25 11:11 risicle