notifications-admin icon indicating copy to clipboard operation
notifications-admin copied to clipboard

Safe placeholder guidance for personalisation

Open saimaghafoor opened this issue 6 months ago • 8 comments

Added safe placeholder guidance. Restructured content to accommodate new guidance.

Please could we add a preview, thanks.

saimaghafoor avatar Jun 02 '25 13:06 saimaghafoor

safe-placeholder

BlessedDev avatar Jun 02 '25 14:06 BlessedDev

placeholder content

BlessedDev avatar Jun 03 '25 11:06 BlessedDev

@rparke - hey Richard, this is ready for review please :)

saimaghafoor avatar Jun 04 '25 09:06 saimaghafoor

@rparke - hey Richard, this is ready for review please :)

Just checking, we don't want this merging to main by itself right? We want it merging to the feature branch for placeholder injection and testing along with the rest of the prototype, then merging after any usability testing changes.

rparke avatar Jun 04 '25 09:06 rparke

Yeah it'll need adding to the prototype in prep for the usability session on Thursday

saimaghafoor avatar Jun 04 '25 09:06 saimaghafoor

Yeah it'll need adding to the prototype in prep for the usability session on Thursday

Cool, it all looks good to me, but we will need to make sure everything gets merged into the right place in the right order.

rparke avatar Jun 04 '25 09:06 rparke

@rparke I've updated the placeholder name from make_safe to secure now. And added the 'edit email template' page content too. So it's good to add to the prototype after you've reviewed it

saimaghafoor avatar Jun 04 '25 10:06 saimaghafoor

@rparke tagging you as I've added the correct placeholder syntax (Edit email template page commit), Thanks!

saimaghafoor avatar Jun 04 '25 14:06 saimaghafoor