govuk_crawler_worker icon indicating copy to clipboard operation
govuk_crawler_worker copied to clipboard

Retry when publisher confirms fail

Open KushalP opened this issue 11 years ago • 2 comments

We're currently monitoring publisher confirms as part of the QueueConnection object but aren't doing anything in the event that a given publish fails. You can see an example of how this can be done from the author of the amqp library we're using here: https://github.com/streadway/amqp/issues/104#issuecomment-46810166

KushalP avatar Jul 02 '14 13:07 KushalP

Noting this here because I think it's relevant:

We set the mandatory and immediate flags to false when publishing a message.

This could lead to circumstances in which messages are silently dropped.

We may need to look at implementing a listener with Channel.NotifyReturn to handle any undeliverable messages when calling publish as per if we enable either of these flags: http://godoc.org/github.com/streadway/amqp#Channel.Publish

mattbostock avatar Jul 31 '14 12:07 mattbostock

Agreed. This is all related to the possibility that the AMQP server tells us it couldn't confirm receipt of a message.

KushalP avatar Jul 31 '14 14:07 KushalP