govuk-prototype-kit icon indicating copy to clipboard operation
govuk-prototype-kit copied to clipboard

Backwards compatibility (v6 support) does not seem to work as documented

Open joelanman opened this issue 6 years ago • 4 comments

This came from a support request

We say:

If any pages or routes exist in both apps, the one in version 7 will win.

I think this is true of routes, but not of pages.

I think to fix pages, in server.js move the if (useV6) { block below this block:

app.get(/^([^.]+)$/, function (req, res, next) {
  utils.matchRoutes(req, res, next)
})

joelanman avatar Sep 12 '19 14:09 joelanman

Might be worth doing this alongside: https://github.com/alphagov/govuk-prototype-kit/issues/799

NickColley avatar Sep 18 '19 13:09 NickColley

This is still an issue. I'm curious to know how teams using v6 compatibility mode are managing with this.

lfdebrux avatar May 19 '22 08:05 lfdebrux

Fixing this would be I think, unfortunately, a breaking change, as users' prototypes could change unexpectedly as a result of it.

lfdebrux avatar May 19 '22 08:05 lfdebrux

since we're removing v6 support I don't think its worth fixing this, and I think it's a minor issue - if you remove the old page, your new page will work

joelanman avatar May 19 '22 08:05 joelanman