govuk-prototype-kit icon indicating copy to clipboard operation
govuk-prototype-kit copied to clipboard

Published 20 hours ago • verified publisher icon alphagov

Namespace SCSS

Open nataliecarey opened this issue 3 years ago • 3 comments

We discussed namespacing our SCSS a while ago but hadn't actually implemented it fully.

This change leaves the app- namespace for user code.

nataliecarey avatar Oct 03 '22 13:10 nataliecarey

I seem to recall us talking about only namespacing new code... I think this change would be breaking? 🤔

lfdebrux avatar Oct 03 '22 13:10 lfdebrux

I didn't remember that nuance of the decision, it makes sense though. I'll leave this open for @joelanman to take a look at. I believe these should really be removed from the core kit so I'm not too worried about whether they get updated now or not.

I think we should be treating these in the same way as we treated step-by-step, releasing NPM packages for them. If we do that soon after the v13 release we're likely to be blocked by them still being built into the kit.

Honestly, I'd be most comfortable deleting them and dumping the current implementations into one or more NPM packages where we can iterate and deprecate more easily than if they're a core part of the kit. This PR was meant to be a small step instead of taking on a bigger chunk of new work but if we think the impact on the user will be too much I guess we can stick with these as they are until v14 (the next breaking change).

nataliecarey avatar Oct 03 '22 14:10 nataliecarey

this would be breaking, and I agree with the direction of making them plugins (installed by default). I think theres a risk that that move might be breaking again, so maybe we wait and do it in one go for v14?

joelanman avatar Oct 04 '22 10:10 joelanman

@nataliecarey I was just reviewing issues/PRs and found this, I think this might be better as an issue? Is it covered by #1653 ?

joelanman avatar Dec 06 '22 12:12 joelanman