govuk-prototype-kit icon indicating copy to clipboard operation
govuk-prototype-kit copied to clipboard

Investigate - New Frontend component imports aren't covered by the update process

Open joelanman opened this issue 3 years ago • 1 comments

What

The GOVUK Frontend components are all imported in app/views/layout.html. We should investigate if thats the right approach, and/or add to the update process.

Why

This is in user space, and is not currently covered by the update process. If a user updates an existing prototype and tries to use a new component, it won't work.

We can tell people to add the new line themselves in release notes, but thats not ideal.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • [ ] We've investigated importing components and have an idea for a new approach

joelanman avatar Jul 22 '22 10:07 joelanman

This feels like something that is part of the wider extensions story... I feel like extensions should be able to tell the kit to import macros into the base layout 🤔

lfdebrux avatar Jul 22 '22 10:07 lfdebrux

I think this is covered by the changes @nataliecarey has suggested for GOV.UK Frontend: https://github.com/alphagov/govuk-frontend/pull/2851

lfdebrux avatar Oct 24 '22 15:10 lfdebrux

@lfdebrux @nataliecarey Lots of moving parts of this one, nearly there: https://github.com/alphagov/govuk-frontend/pull/2851#issuecomment-1292188131

Please jump on with any extra feedback

Just updating our build to write out the config

colinrotherham avatar Oct 26 '22 15:10 colinrotherham

I think this one is done - we have a new approach, awaiting next Frontend release

joelanman avatar Oct 28 '22 18:10 joelanman