govuk-frontend icon indicating copy to clipboard operation
govuk-frontend copied to clipboard

Investigate customised colours on details component in IE11

Open NickColley opened this issue 7 years ago • 7 comments

Some components relying on 'clip-path' may be displaying in a way that is not ideal in IE11 / Edge, which don't support clip-path.

back links high contrast gov uk

This may also be a problem with the details component.

I think maybe our best bet is to change these icons to use inline SVGs with currentColor fills.

  • https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6519995-support-clip-path-property
  • https://caniuse.com/#feat=css-clip-path

NickColley avatar Aug 02 '18 16:08 NickColley

Great presentation on this: https://noti.st/ericwbailey/3HM9en

NickColley avatar Nov 28 '18 10:11 NickColley

We observed this issue while testing Apply for teacher training at the Digital Accessibility Centre (DAC).

fofr avatar Dec 17 '19 09:12 fofr

This is no longer relevant for the back link component, but still applies to the details component.

36degrees avatar Jun 02 '20 09:06 36degrees

I can't reproduce this with the Design System details component in Edge or Chrome on Windows 10 (worth noting that the Windows High Contrast mode itself doesn’t work on Chrome on Windows 10, you’re asked to install the Chrome High Contrast extension instead so I tested with that).

hannalaakso avatar Mar 04 '21 17:03 hannalaakso

This was reported as an issue on the Details component in IE11 by DAC when performing an assessment of the Vulnerable People Service.

pipwilson avatar Mar 04 '21 17:03 pipwilson

I can't reproduce this with the Design System details component in Edge or Chrome on Windows 10 (worth noting that the Windows High Contrast mode itself doesn’t work on Chrome on Windows 10, you’re asked to install the Chrome High Contrast extension instead so I tested with that).

I suspect this affected Edge pre-Chromium, which never supported clip-path as far as I can tell.

Worth updating the title to remove the mention of Edge, do you reckon?

36degrees avatar Mar 04 '21 17:03 36degrees

For the record, this is how the details component looks like in IE11 with Windows High Contrast mode: Screenshot 2021-03-11 at 09 55 57

hannalaakso avatar Mar 11 '21 09:03 hannalaakso

From Frontend v5 we will no longer ship an interactive Details component for IE 11, as we've removed the polyfill for legacy browsers, including Internet Explorer. Details elements will always be shown as expanded in IE.

querkmachine avatar Aug 11 '23 13:08 querkmachine

Going to close this off now as Frontend v5 has been released and all situations where clip-path'd elements are used are no longer present on IE11.

  • Back Link no longer uses clip-path.
  • Details is no longer expandable or collapsible as the polyfill has been removed. They always appear expanded.
  • Headers with navigation items are no longer expandable or collapsible on narrow screens, as IE11 no longer executes JavaScript. Menus are always expanded.

querkmachine avatar Jan 12 '24 14:01 querkmachine