govuk-frontend icon indicating copy to clipboard operation
govuk-frontend copied to clipboard

Header component CSS is accounting for users not building the header component correctly

Open owenatgov opened this issue 2 years ago • 0 comments

Cause

With https://github.com/alphagov/govuk-frontend/pull/2727 we added some additional CSS to account for is teams hadn't added the extra hidden attribute to the menu button if they're not using our macros to stop the change resulting in a regression. In the next breaking release, we should amend this CSS to presume that teams have updated their macros and clean up the offending CSS.

Consequences

We are shipping CSS that is only necessary for a specific case that we expect to not be a problem with the next breaking release.

We are shipping CSS that is inconsistent within the same file with how we handle hiding elements as a fallback for when hidden isn't supported.

Impact of debt

Low

Reason (impact of debt)

No response

Effort to pay down

Low

Reason (effort to pay down)

No response

Overall rating

Low

Reason (overall rating)

No response

owenatgov avatar Aug 03 '22 13:08 owenatgov