collections
collections copied to clipboard
[WIP] Redesign No. 10 organisation page
What
- Redesign No. 10 organisation page
Why
- https://trello.com/c/uXnyGiIa/76-frontend-changes-to-no10-page?filter=label:No%2010%20Org%20page
Things for frontend to look at:
- [x] Latest news page
- [x] ~~The image card is always
large: true
when a YouTube video is present, causing a formatting issue, so component change is needed~~
Things for backend to look at:
- [x] Latest news doesn't come with the right data for the image card component so ive hacked it for now.
- Also I can't figure out how to remove the duplicate news item from the list to the right of it (doing .shift(), .drop() etc on the array doesn't work)
- [x] I can't change the colour of the contacts links as they're coming through from the backend, at
app/presenters/organisations/contacts_presenter.rb
line 68 (basically you need to remove brand__color if its the no 10 page) and I can't figure out how to do it as the@org.is_no_10?
boolean doesn't work in that presenter - [ ] The follow links rendering relies on
@what_we_do.has_share_links?
, so maybe they can't remove the 'what we do' section from Whitehall? - [x] Question around tests - they seem to be complaining that I haven't added loads of translations for the new strings I've added. Is there a way to make the tests ignore them? Or should we be getting translations for these new strings?