ENH support for greedy with dicodile
Codecov Report
Merging #105 (2168ff8) into master (8bd4756) will decrease coverage by
1.89%. The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 82.14% 80.25% -1.89%
==========================================
Files 22 22
Lines 2172 2172
==========================================
- Hits 1784 1743 -41
- Misses 388 429 +41
any docstring to update or whats new entry to add?
We agreed with @rprimet that we should also add in this PR an example on sample with dicodile that is faster on our cluster.
Also, the error in the test seems legit, we should make sure we investigate it @rprimet
Yes the test error seems legit, we might also add dicodile to the test matrix (it was just found at the coverage step which feels weird...)
looks like releasing + bumping the dicodile version fixes that
Ok, so now, we need to create an example that shows we go faster :)