alphacsc icon indicating copy to clipboard operation
alphacsc copied to clipboard

ENH support for greedy with dicodile

Open tomMoral opened this issue 3 years ago • 6 comments

tomMoral avatar Nov 16 '22 14:11 tomMoral

Codecov Report

Merging #105 (2168ff8) into master (8bd4756) will decrease coverage by 1.89%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   82.14%   80.25%   -1.89%     
==========================================
  Files          22       22              
  Lines        2172     2172              
==========================================
- Hits         1784     1743      -41     
- Misses        388      429      +41     

codecov-commenter avatar Nov 16 '22 14:11 codecov-commenter

any docstring to update or whats new entry to add?

agramfort avatar Nov 16 '22 21:11 agramfort

We agreed with @rprimet that we should also add in this PR an example on sample with dicodile that is faster on our cluster.

Also, the error in the test seems legit, we should make sure we investigate it @rprimet

tomMoral avatar Nov 17 '22 10:11 tomMoral

Yes the test error seems legit, we might also add dicodile to the test matrix (it was just found at the coverage step which feels weird...)

rprimet avatar Nov 17 '22 12:11 rprimet

looks like releasing + bumping the dicodile version fixes that

rprimet avatar Nov 21 '22 16:11 rprimet

Ok, so now, we need to create an example that shows we go faster :)

tomMoral avatar Nov 21 '22 16:11 tomMoral